[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979043#comment-16979043
]
Yiqun Lin commented on HDFS-14651:
----------------------------------
The latest patch almost looks good now, only some minor comments:
{quote}Should we make CONNECTION_TIMEOUT_MS configurable?
{quote}
Yes, you can add this if it's really needed. I suggest to use the setting
name/description.
dfs.client.deadnode.detection.probe.connection.timeout.ms: Connection timeout
for probing dead node in milliseconds.
{code:java}
+ Future<DatanodeLocalInfo> future = rpcThreadPool.submit(new Callable()
{
+ @Override
+ public DatanodeLocalInfo call() throws Exception {
+ return proxy.getDatanodeInfo();
+ }
+
+ }); <---- format this line
{code}
Can you format above line?
Can we update '{{Remove the node out from dead}}' to '{{Remove the node out
from dead node list}}'?
*TestDeadNodeDetection.java*
Revisit for this unit test, we need additional test for the deadnode queue max
limitation. We can just limit 1 as max queue limitation and then verify in
test. Would you mind adding this additional test, [~leosun08]? Also actually I
saw some duplicated lines in this unit test, we can make a simple refactor in
followup task.
Others looks good to me.
> DeadNodeDetector checks dead node periodically
> ----------------------------------------------
>
> Key: HDFS-14651
> URL: https://issues.apache.org/jira/browse/HDFS-14651
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Lisheng Sun
> Assignee: Lisheng Sun
> Priority: Major
> Attachments: HDFS-14651.001.patch, HDFS-14651.002.patch,
> HDFS-14651.003.patch, HDFS-14651.004.patch, HDFS-14651.005.patch,
> HDFS-14651.006.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
