[
https://issues.apache.org/jira/browse/HDFS-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979370#comment-16979370
]
Yiqun Lin commented on HDFS-14651:
----------------------------------
Thanks for updating the patch, [~leosun08]. The patch looks very great now,
only two comments:
* Can we exclude this unrelated change?
{code:java}
</dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-library</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
{code}
* We need to add a Thread.sleep(1500) before asset check to ensure that
detector does the probe dead node one time.
* Also can we update the asset check to following, we ensure that the dead
node and probe queue node is no more than 3 in one iteration. I don't prefer to
introduce a new dependency in hdfs module that only used here.
{code:java}
Thread.sleep(1500);
Assert.assertTrue((dfsClient.getClientContext().getDeadNodeDetector()
+ .getDeadNodesProbeQueue().size() +
dfsClient.getDeadNodes(din).size()) < 3);
{code}
> DeadNodeDetector checks dead node periodically
> ----------------------------------------------
>
> Key: HDFS-14651
> URL: https://issues.apache.org/jira/browse/HDFS-14651
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Lisheng Sun
> Assignee: Lisheng Sun
> Priority: Major
> Attachments: HDFS-14651.001.patch, HDFS-14651.002.patch,
> HDFS-14651.003.patch, HDFS-14651.004.patch, HDFS-14651.005.patch,
> HDFS-14651.006.patch, HDFS-14651.007.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
