[
https://issues.apache.org/jira/browse/HDFS-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983598#comment-16983598
]
Jim Brennan commented on HDFS-14960:
------------------------------------
[~hemanthboyina] that does seem like a reasonable check to me, and likely would
have caught the problem reported in HDFS-14958. I think the intent of this
Jira is to improve the test so that it includes some test cases that are unique
to NetworkTopologyWithNodeGroup. The fact that it was succeeding when it
wasn't using the right class suggests that it could be improved.
> TesteBalancerWithNodeGroup should not succeed with DFSNetworkTopology
> ---------------------------------------------------------------------
>
> Key: HDFS-14960
> URL: https://issues.apache.org/jira/browse/HDFS-14960
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.1.3
> Reporter: Jim Brennan
> Priority: Minor
>
> As reported in HDFS-14958, TestBalancerWithNodeGroup was succeeding even
> though it was using DFSNetworkTopology instead of
> NetworkTopologyWithNodeGroup.
> [~inigoiri] rightly suggested that this indicates the test is not very good -
> it should fail when run without NetworkTopologyWithNodeGroup.
> We should improve this test.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
