[ 
https://issues.apache.org/jira/browse/HDFS-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983809#comment-16983809
 ] 

Íñigo Goiri commented on HDFS-14960:
------------------------------------

Let's add the check and make the test more specific so it would fail anyway 
without the check.

> TesteBalancerWithNodeGroup should not succeed with DFSNetworkTopology
> ---------------------------------------------------------------------
>
>                 Key: HDFS-14960
>                 URL: https://issues.apache.org/jira/browse/HDFS-14960
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.1.3
>            Reporter: Jim Brennan
>            Priority: Minor
>
> As reported in HDFS-14958, TestBalancerWithNodeGroup was succeeding even 
> though it was using DFSNetworkTopology instead of 
> NetworkTopologyWithNodeGroup.
> [~inigoiri] rightly suggested that this indicates the test is not very good - 
> it should fail when run without NetworkTopologyWithNodeGroup.
> We should improve this test.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to