[
https://issues.apache.org/jira/browse/HDFS-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012084#comment-17012084
]
Íñigo Goiri commented on HDFS-15108:
------------------------------------
Thanks for bringing this up, can you give a little more context on what was the
effect you saw?
A minor comment, I would avoid changing the
FederationNamenodeServiceState.STANDBY to STANDBY in this JIRA.
Given that we have HAServiceState.STANDBY and
FederationNamenodeServiceState.STANDBY, I prefer stating both.
This is hard to read:
{code}
297 String rpcAddr = namenode.getRpcAddress();
298 int port = Integer
299 .parseInt(rpcAddr.substring(rpcAddr.indexOf(":") +1,
rpcAddr.length()));
300 InetSocketAddress inetAddr =
301 new InetSocketAddress(rpcAddr.substring(0,
rpcAddr.indexOf(':')), port);
{code}
Can we extract this so we have a comment mentioning what is the high level idea?
I really don't get what this is doing as you will probably end up with just
String to InetSocketAddress.
> RBF: MembershipNamenodeResolver should invalidate cache incase of active
> namenode update
> ----------------------------------------------------------------------------------------
>
> Key: HDFS-15108
> URL: https://issues.apache.org/jira/browse/HDFS-15108
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-15108-01.patch
>
>
> If a failover happens, {{namenodeResolver.updateActiveNamenode(nsId,
> address);}} is called, but this doesn't invalidates the cache, so as the next
> time the correct active is fetched.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
