[ 
https://issues.apache.org/jira/browse/HDFS-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013067#comment-17013067
 ] 

Íñigo Goiri commented on HDFS-15108:
------------------------------------

Thanks [~ayushtkn] for the update.
A couple minor style comments:
* I would make the invalidation into a method: {{invalidateCache(final String 
nsId)}} where we would do the code you have there.
* Let's make getInetSocketAddress() static.
* In the javadoc for getInetSocketAddress() mention is the format host:port.

> RBF: MembershipNamenodeResolver should invalidate cache incase of active 
> namenode update
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-15108
>                 URL: https://issues.apache.org/jira/browse/HDFS-15108
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-15108-01.patch, HDFS-15108-02.patch, 
> HDFS-15108-03.patch
>
>
> If a failover happens, {{namenodeResolver.updateActiveNamenode(nsId, 
> address);}} is called, but this doesn't invalidates the cache, so as the next 
> time the correct active is fetched.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to