[
https://issues.apache.org/jira/browse/HDFS-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029482#comment-17029482
]
Konstantin Shvachko commented on HDFS-15111:
--------------------------------------------
Thanks for the patch [~risyomei].
* It is better to use placeholders in LOG statements, like
{code:java}
LOG.info("Stopping services started for {} state", curState);{code}
* For {{curState}} you can make it of type {{HAServiceState}}, and use
{{FSNamesystem.getState()}}, which already takes care of the context null value.
> start / stopStandbyServices() should log which service it is transitioning
> to/from.
> -----------------------------------------------------------------------------------
>
> Key: HDFS-15111
> URL: https://issues.apache.org/jira/browse/HDFS-15111
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, logging
> Affects Versions: 2.10.0
> Reporter: Konstantin Shvachko
> Assignee: Xieming Li
> Priority: Major
> Labels: newbie++
> Attachments: HDFS-15111.001.patch, HDFS-15111.002.patch
>
>
> Trying to transition Observer to Standby state. Both
> {{stopStandbyServices()}} and {{startStandbyServices()}} log that they are
> stopping/starting Standby services.
> # {{startStandbyServices()}} should log which state it is transitioning TO.
> # {{stopStandbyServices()}} should log which state it is transitioning FROM.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
