[ 
https://issues.apache.org/jira/browse/HDFS-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029569#comment-17029569
 ] 

Ayush Saxena commented on HDFS-15111:
-------------------------------------

I think the logging should be either standby or observer only, There are other 
states like initializing or Stopping, in that case IMO we should log standby 
only, It won't make sense stopping services started for Initializing state. So 
we should ensure log only standby or observer

> start / stopStandbyServices() should log which service it is transitioning 
> to/from.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-15111
>                 URL: https://issues.apache.org/jira/browse/HDFS-15111
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs, logging
>    Affects Versions: 2.10.0
>            Reporter: Konstantin Shvachko
>            Assignee: Xieming Li
>            Priority: Major
>              Labels: newbie++
>         Attachments: HDFS-15111.001.patch, HDFS-15111.002.patch
>
>
> Trying to transition Observer to Standby state. Both 
> {{stopStandbyServices()}} and {{startStandbyServices()}} log that they are 
> stopping/starting Standby services.
> # {{startStandbyServices()}} should log which state it is transitioning TO.
> # {{stopStandbyServices()}} should log which state it is transitioning FROM.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to