[ 
https://issues.apache.org/jira/browse/HDFS-15255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076104#comment-17076104
 ] 

Lisheng Sun commented on HDFS-15255:
------------------------------------

{quote}FindBugs:Call to 
org.apache.hadoop.hdfs.protocol.DatanodeInfoWithStorage.equals(org.apache.hadoop.hdfs.server.blockmanagement.DatanodeDescriptor)
 in 
org.apache.hadoop.hdfs.server.namenode.CacheManager.setCachedLocations(LocatedBlock)
 At CacheManager.java: At CacheManager.java:[line 955]
 Bug type EC_UNRELATED_TYPES (click for details)
{quote}
About this error, I do n’t know where the problem is.

DatanodeInfoWithStorage and DatanodeDescriptor also extend DatanodeInfo and 
overwrite equals(). 
 i runTestCacheDirectives#testNoLookupsWhenNotUsed that call 
CacheManager#setCachedLocations in local successfully. 
 i use the jdk is openjdk version "1.8.0_242"

hi [~elgoiri] [~sodonnell] [~weichiu]  [~ayushtkn]  Could you have time help 
review this patch? Thank you.

> Consider StorageType when DatanodeManager#sortLocatedBlock()
> ------------------------------------------------------------
>
>                 Key: HDFS-15255
>                 URL: https://issues.apache.org/jira/browse/HDFS-15255
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Lisheng Sun
>            Assignee: Lisheng Sun
>            Priority: Major
>         Attachments: HDFS-15255.001.patch
>
>
> When only one replica of a block is SDD, the others are HDD. 
> When the client reads the data, the current logic is that it considers the 
> distance between the client and the dn. I think it should also consider the 
> StorageType of the replica. Priority to return a replica of the specified 
> StorageType



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to