[
https://issues.apache.org/jira/browse/HDFS-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119005#comment-17119005
]
Íñigo Goiri commented on HDFS-14960:
------------------------------------
Minor comments:
* As L198 only has one equals, let's use assertEquals().
* In verifyProperBlockPlacement(), the assertTrue() could give the block id
when failing.
* Should verifyProperBlockPlacement() assert that there was at least a block to
check? assertFalse(locatedBlocks.isEmpty())
> TestBalancerWithNodeGroup should not succeed with DFSNetworkTopology
> --------------------------------------------------------------------
>
> Key: HDFS-14960
> URL: https://issues.apache.org/jira/browse/HDFS-14960
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.1.3
> Reporter: Jim Brennan
> Assignee: Jim Brennan
> Priority: Minor
> Attachments: HDFS-14960.001.patch, HDFS-14960.002.patch,
> HDFS-14960.003.patch, HDFS-14960.004.patch
>
>
> As reported in HDFS-14958, TestBalancerWithNodeGroup was succeeding even
> though it was using DFSNetworkTopology instead of
> NetworkTopologyWithNodeGroup.
> [~inigoiri] rightly suggested that this indicates the test is not very good -
> it should fail when run without NetworkTopologyWithNodeGroup.
> We should improve this test.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
