[
https://issues.apache.org/jira/browse/HDFS-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120154#comment-17120154
]
Ayush Saxena commented on HDFS-14960:
-------------------------------------
Thanx [~Jim_Brennan] for the patch.
Minor nit :
{code:java}
Assert.assertEquals("Balancer did not exit with NO_MOVE_PROGRESS",
{code}
{{assertEquals}} is already imported, this can be just {{assertEquals}} rather
than {{Assert.assertEquals}}
Apart from that LGTM
> TestBalancerWithNodeGroup should not succeed with DFSNetworkTopology
> --------------------------------------------------------------------
>
> Key: HDFS-14960
> URL: https://issues.apache.org/jira/browse/HDFS-14960
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.1.3
> Reporter: Jim Brennan
> Assignee: Jim Brennan
> Priority: Minor
> Attachments: HDFS-14960.001.patch, HDFS-14960.002.patch,
> HDFS-14960.003.patch, HDFS-14960.004.patch, HDFS-14960.005.patch
>
>
> As reported in HDFS-14958, TestBalancerWithNodeGroup was succeeding even
> though it was using DFSNetworkTopology instead of
> NetworkTopologyWithNodeGroup.
> [~inigoiri] rightly suggested that this indicates the test is not very good -
> it should fail when run without NetworkTopologyWithNodeGroup.
> We should improve this test.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
