[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135615#comment-17135615
]
Jinglun commented on HDFS-15346:
--------------------------------
Your are genius [~linyiqun] ! Thanks your brilliant comments, the improvement
is great ! The unit tests run very fast now. I followed up all the changes. And
I did a little refactor based on your improvement. The logic of the improvement
is the same as you suggested. I only extracted a method and refactored the
class RunningJobStatus to make it easier to read. Please let me know your
thoughts, I'm also ok to keep it just the same as you suggested.
{quote}Can you update following description in router option? I update this
content as well but seems this was not addressed in the latest patch.
{quote}
Sorry I missed this. Update at v11.
{quote}Method name cleanUpBeforeInitDistcp can be renamed to
pathCheckBeforeInitDistcp since we don't do any cleanup operation now.
{quote}
Address at v11.
> RBF: DistCpFedBalance implementation
> ------------------------------------
>
> Key: HDFS-15346
> URL: https://issues.apache.org/jira/browse/HDFS-15346
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15346.001.patch, HDFS-15346.002.patch,
> HDFS-15346.003.patch, HDFS-15346.004.patch, HDFS-15346.005.patch,
> HDFS-15346.006.patch, HDFS-15346.007.patch, HDFS-15346.008.patch,
> HDFS-15346.009.patch, HDFS-15346.010.patch, HDFS-15346.011.patch
>
>
> Patch in HDFS-15294 is too big to review so we split it into 2 patches. This
> is the second one. Detail can be found at HDFS-15294.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
