[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135819#comment-17135819
]
Yiqun Lin commented on HDFS-15346:
----------------------------------
[~LiJinglun], the refactor looks great. I find you decrease the timeout value,
the new value seems too small and it will lead timeout error.
Can you adjust all this time value to 30000(@Test(timeout = 30000) in
TestDistCpProcedure? This value works well in my local.
Finally, can we add 'fedbalance' in current package name under fedbalance
module?
Under module path src/test/java, src/main/java
Update
{noformat}
org.apache.hadoop.tools
org.apache.hadoop.tools.procedure
{noformat}
to
{noformat}
org.apache.hadoop.tools.fedbalance
org.apache.hadoop.tools.fedbalance.procedure
{noformat}
Then please check and update some old class path that used in the module, like
hadoop-federation-balance.sh, pom.xml or some other place.
Others looks good to me now. Thanks [~LiJinglun] for the so patient working for
this.
Once above are addressed, I will hold off the commit for few days in case there
are some other comments from others.
> RBF: DistCpFedBalance implementation
> ------------------------------------
>
> Key: HDFS-15346
> URL: https://issues.apache.org/jira/browse/HDFS-15346
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15346.001.patch, HDFS-15346.002.patch,
> HDFS-15346.003.patch, HDFS-15346.004.patch, HDFS-15346.005.patch,
> HDFS-15346.006.patch, HDFS-15346.007.patch, HDFS-15346.008.patch,
> HDFS-15346.009.patch, HDFS-15346.010.patch, HDFS-15346.011.patch
>
>
> Patch in HDFS-15294 is too big to review so we split it into 2 patches. This
> is the second one. Detail can be found at HDFS-15294.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
