[
https://issues.apache.org/jira/browse/HDFS-15551?focusedWorklogId=477566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-477566
]
ASF GitHub Bot logged work on HDFS-15551:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Sep/20 02:12
Start Date: 02/Sep/20 02:12
Worklog Time Spent: 10m
Work Description: imbajin commented on a change in pull request #2265:
URL: https://github.com/apache/hadoop/pull/2265#discussion_r481554949
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
##########
@@ -181,6 +181,8 @@ private boolean isPeriodicRefreshEnabled() {
private byte[] oneByteBuf; // used for 'int read()'
protected void addToLocalDeadNodes(DatanodeInfo dnInfo) {
+ DFSClient.LOG.debug("Add {} to local dead nodes, previously was {}",
Review comment:
1. From the statistics of the production environment, the log output of
local `deadnode` information is too few, so that it is troublesome to find the
problem reason, now add it as `DEBUG`
2. The reason to use the `DEBUG` log level is to separate from the `INFO`
log level of the detector, and the impact is small.
3. Remove logs can be added at the same time(I think both are OK). It was
not added before considering that the local dead node removal method will
almost never be called, unless the detector is turned on and then called, and
there is already log output there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 477566)
Time Spent: 0.5h (was: 20m)
> Tiny Improve for DeadNode detector
> ----------------------------------
>
> Key: HDFS-15551
> URL: https://issues.apache.org/jira/browse/HDFS-15551
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 3.3.0
> Reporter: dark_num
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> # add or improve some logs for adding local & global deadnodes
> # logic improve
> # fix typo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
