[
https://issues.apache.org/jira/browse/HDFS-15551?focusedWorklogId=478934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-478934
]
ASF GitHub Bot logged work on HDFS-15551:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/20 04:49
Start Date: 04/Sep/20 04:49
Worklog Time Spent: 10m
Work Description: leosunli commented on a change in pull request #2265:
URL: https://github.com/apache/hadoop/pull/2265#discussion_r483382751
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DeadNodeDetector.java
##########
@@ -475,6 +475,7 @@ public synchronized void addNodeToDetect(DFSInputStream
dfsInputStream,
datanodeInfos.add(datanodeInfo);
}
+ LOG.warn("Add datanode {} to suspectAndDeadNodes", datanodeInfo);
Review comment:
One case: when a lot of invalid relicas, will the log flood?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DeadNodeDetector.java
##########
@@ -396,13 +395,13 @@ private void probeCallBack(Probe probe, boolean success) {
probe.getDatanodeInfo());
removeDeadNode(probe.getDatanodeInfo());
} else if (probe.getType() == ProbeType.CHECK_SUSPECT) {
- LOG.debug("Remove the node out from suspect node list: {}.",
+ LOG.info("Remove the node out from suspect node list: {}.",
Review comment:
when a lot of invalid relicas, it should have many supsect nodes but
not dead nodes.
These nodes all will print this log.
What is the purpose of printing this log?
The client can access normally the suspect node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 478934)
Time Spent: 50m (was: 40m)
> Tiny Improve for DeadNode detector
> ----------------------------------
>
> Key: HDFS-15551
> URL: https://issues.apache.org/jira/browse/HDFS-15551
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 3.3.0
> Reporter: dark_num
> Assignee: imbajin
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> # add or improve some logs for adding local & global deadnodes
> # logic improve
> # fix typo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
