[
https://issues.apache.org/jira/browse/HDFS-15659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222107#comment-17222107
]
Akira Ajisaka edited comment on HDFS-15659 at 10/28/20, 11:29 AM:
------------------------------------------------------------------
Thank you [~ayushtkn] for your comment.
{quote}IIRC couple of days back you had objections having this config disabled
in a test. I didn't follow up, and I lost the track of that Jira too. Is that
concern not there now?
{quote}
The comment is here:
[https://github.com/apache/hadoop/pull/2404#pullrequestreview-515448731]
Sorry, I've changed my mind. For fixing one test, I thought it's okay to
increase the number of DNs. However, for fixing many tests, it's easier to
disable this feature by default rather than increasing the number of DNs for
each test case.
{quote}So, If this concludes, We can revert that. Increasing datanodes has
adverse affect on test performance, though minor
{quote}
Yes, I think we can revert HDFS-15461 if the feature is disabled by default.
was (Author: ajisakaa):
Thank you [~ayushtkn] for your comment.
{quote}IIRC couple of days back you had objections having this config disabled
in a test. I didn't follow up, and I lost the track of that Jira too. Is that
concern not there now?
{quote}
The comment is here:
[https://github.com/apache/hadoop/pull/2404#pullrequestreview-515448731]
Sorry, I've changed my mind. For fixing one test, I thought it's okay to
increase the number of DNs. However, for fixing many tests,
it's easier to disable this feature by default rather than increasing the
number of DNs for each test case.
{quote}So, If this concludes, We can revert that. Increasing datanodes has
adverse affect on test performance, though minor
{quote}
Yes, I think we can revert HDFS-15461 if the feature is disabled by default.
> Set dfs.namenode.redundancy.considerLoad to false in MiniDFSCluster
> -------------------------------------------------------------------
>
> Key: HDFS-15659
> URL: https://issues.apache.org/jira/browse/HDFS-15659
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Akira Ajisaka
> Priority: Major
>
> dfs.namenode.redundancy.considerLoad is true by default and it is causing
> many test failures. Let's disable it in MiniDFSCluster.
> Originally reported by [~weichiu]:
> https://github.com/apache/hadoop/pull/2410#pullrequestreview-516144442
> {quote}
> i've certain seen this option causing test failures in the past.
> Maybe we should turn it off by default in MiniDDFSCluster, and only enable it
> for specific tests.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
