[ 
https://issues.apache.org/jira/browse/HDFS-15665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225011#comment-17225011
 ] 

Chen Liang commented on HDFS-15665:
-----------------------------------

Thanks for working on this [~shv]! v001 patch looks good to me. Just two minor 
comments:

1. The {{getInt}} line Balancer.java:L#286 seems redundant? no variable is 
taking that value
2. Balancer.java:L#663 and L#665, the two LOG.info lines, would it be better to 
merge them to one line?

> Balancer logging improvement
> ----------------------------
>
>                 Key: HDFS-15665
>                 URL: https://issues.apache.org/jira/browse/HDFS-15665
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: balancer & mover
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Major
>         Attachments: HDFS-15665.001.patch
>
>
> It would be good to have Balancer log all relevant configuration parameters 
> on each iteration along with some data, which reflects its progress and the 
> amount of resources it involves.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to