[
https://issues.apache.org/jira/browse/HDFS-15665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225092#comment-17225092
]
Konstantin Shvachko commented on HDFS-15665:
--------------------------------------------
Thanks for the review [~vagarychen].
* {{getInt()}} is actually called to print a log message for the parameter. The
value itself may not be used in the Balancer itself.
* Two log messages looks better infact. Because the firs message is pretty long
as it prints {{NameNodeConnector}} including URI and block pool id
{noformat:nowrap}
2020-11-02 10:42:59,939 [Listener at localhost/64077] INFO balancer.Balancer
(Balancer.java:runOneIteration(641)) - Will move 100.79 MB in this iteration
for NameNodeConnector[namenodeUri=hdfs://localhost:64069,
bpid=BP-79516876-172.18.170.12-1604342573024]
{noformat}
So if I append the second line it will be hard to read the logs.
Will update the patch with checkstyle fixes.
> Balancer logging improvement
> ----------------------------
>
> Key: HDFS-15665
> URL: https://issues.apache.org/jira/browse/HDFS-15665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Priority: Major
> Attachments: HDFS-15665.001.patch
>
>
> It would be good to have Balancer log all relevant configuration parameters
> on each iteration along with some data, which reflects its progress and the
> amount of resources it involves.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
