[ https://issues.apache.org/jira/browse/HDFS-15737?focusedWorklogId=525848&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-525848 ]
ASF GitHub Bot logged work on HDFS-15737: ----------------------------------------- Author: ASF GitHub Bot Created on: 18/Dec/20 02:44 Start Date: 18/Dec/20 02:44 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2562: URL: https://github.com/apache/hadoop/pull/2562#issuecomment-747831900 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 11m 7s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.10 Compile Tests _ | | +1 :green_heart: | mvninstall | 16m 8s | branch-2.10 passed | | +1 :green_heart: | compile | 0m 58s | branch-2.10 passed | | +1 :green_heart: | checkstyle | 0m 38s | branch-2.10 passed | | +1 :green_heart: | mvnsite | 1m 12s | branch-2.10 passed | | +1 :green_heart: | javadoc | 1m 15s | branch-2.10 passed | | +0 :ok: | spotbugs | 2m 59s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 2m 56s | branch-2.10 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 0s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | checkstyle | 0m 29s | the patch passed | | +1 :green_heart: | mvnsite | 1m 2s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 1m 10s | the patch passed | | +1 :green_heart: | findbugs | 3m 0s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 62m 34s | hadoop-hdfs in the patch failed. | | +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. | | | | 108m 52s | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys | | | hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain | | | hadoop.hdfs.TestRollingUpgrade | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2562/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2562 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 8cd430b18ff7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | branch-2.10 / 2c45e93 | | Default Java | Oracle Corporation-1.7.0_95-b00 | | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2562/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2562/1/testReport/ | | Max. process+thread count | 2255 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2562/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 525848) Time Spent: 50m (was: 40m) > Don't remove datanodes from outOfServiceNodeBlocks while checking in > DatanodeAdminManager > ----------------------------------------------------------------------------------------- > > Key: HDFS-15737 > URL: https://issues.apache.org/jira/browse/HDFS-15737 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: Ye Ni > Assignee: Ye Ni > Priority: Major > Labels: pull-request-available > Fix For: 2.10.2 > > Time Spent: 50m > Remaining Estimate: 0h > > With CyclicIteration, remove an item while iterating causes either dead loop > or ConcurrentModificationException. > This item should be removed by > {{toRemove.add(dn);}} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org