[
https://issues.apache.org/jira/browse/HDFS-15737?focusedWorklogId=526158&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-526158
]
ASF GitHub Bot logged work on HDFS-15737:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Dec/20 21:54
Start Date: 18/Dec/20 21:54
Worklog Time Spent: 10m
Work Description: NickyYe commented on pull request #2562:
URL: https://github.com/apache/hadoop/pull/2562#issuecomment-748338149
> Thanks for the information - this may explain why HDFS-12703 was needed,
as some exceptions which were not logged at that time, caused the decommission
thread to stop running until the NN was restarted. The change there was to
catch the exception.
>
> The change here looks correct to me, but as the issue exists on the trunk
branch, we should fix it there first, and then backport to 3.3, 3.2, 3.1 and
2.10 so the fix is in place across all branches.
Due to HDFS-14854, the fix on trunk could be a very different one, since it
doesn't make sense to change the new interface with a boolean parameter to
stopTrackingNode while DatanodeAdminBackoffMonitor does't need.
Looks a better fix would be introduce a cancelledNodes to
DatanodeAdminDefaultMonitor, just like DatanodeAdminBackoffMonitor . Then in
stopTrackingNode, don't remove dn from outOfServiceNodeBlocks, but add it to
cancelledNodes for further process.
However, the change would be a little bit bigger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 526158)
Time Spent: 1.5h (was: 1h 20m)
> Don't remove datanodes from outOfServiceNodeBlocks while checking in
> DatanodeAdminManager
> -----------------------------------------------------------------------------------------
>
> Key: HDFS-15737
> URL: https://issues.apache.org/jira/browse/HDFS-15737
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Ye Ni
> Assignee: Ye Ni
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.10.2
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> With CyclicIteration, remove an item while iterating causes either dead loop
> or ConcurrentModificationException.
> This item should be removed by
> {{toRemove.add(dn);}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
