[ 
https://issues.apache.org/jira/browse/HDFS-15767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259942#comment-17259942
 ] 

Íñigo Goiri commented on HDFS-15767:
------------------------------------

Let's try to isolate the code for the distributed rename a little.
* Can we move the core of the changes to RouterClientProtocol into a separate 
file?
* In RouterRpcServer, can we move the code to initialize the renamer into a 
separate method?
* The name scheduler in RouterRpcServer is a little vague, can we add some 
reference to rename?
* Can we leave TestRouterRpc without any of the renaming across namespaces and 
create a full new file with the renaming?
* I'm a little concerned with the distcp dependency for testing in RBF; they 
are only for testing but not sure is the cleanest to have this implicit 
circular dependencies.

> RBF: Router federation rename of directory.
> -------------------------------------------
>
>                 Key: HDFS-15767
>                 URL: https://issues.apache.org/jira/browse/HDFS-15767
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Jinglun
>            Assignee: Jinglun
>            Priority: Major
>         Attachments: HDFS-15767.001.patch
>
>
> This Jira trys to support rename of directory across namespaces using 
> fedbalance framework. 
> We can do the router federation rename when:
>  # Both the src and dst has only one remote location.
>  # The src and dst remote locations are at different namespaces.
>  # The src is a directory.(Fedbalance depends on snapshot).
>  # The dst doesn't exist.
> We can implement router federation rename of file in a new task so the patch 
> won't be too big to review.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to