[
https://issues.apache.org/jira/browse/HDFS-15767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268697#comment-17268697
]
Ayush Saxena commented on HDFS-15767:
-------------------------------------
Thanx [~LiJinglun] for the patch, I had a quick look and changes looks good
[~elgoiri] has already done the major review part. :)
One suggestion :
{code:java}
355 public static final String DFS_ROUTER_FEDERATION_RENAME_ENABLE =
356 DFS_ROUTER_FEDERATION_RENAME_PREFIX + "enable";
357 public static final boolean DFS_ROUTER_FEDERATION_RENAME_ENABLE_DEFAULT =
358 false;
{code}
Instead of having a boolean config, can we specify modes like NONE for disable,
DistCp for the present, giving room to accommodate other modes of copy, like
hard links, and others.
Secondly when can we hit this :
{code:java}
92 if (srcLoc.getNameserviceId().equals(dstLoc.getNameserviceId())) {
93 throw new IOException(
94 "Rename of " + src + " to " + dst + " are at the same namespace.");
95 }
{code}
if nameservice is same, won't we do a normal copy itself before only?
Rest there are complains from jenkins, you need to give a check
> RBF: Router federation rename of directory.
> -------------------------------------------
>
> Key: HDFS-15767
> URL: https://issues.apache.org/jira/browse/HDFS-15767
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15767.001.patch, HDFS-15767.002.patch,
> HDFS-15767.003.patch, HDFS-15767.004.patch
>
>
> This Jira trys to support rename of directory across namespaces using
> fedbalance framework.
> We can do the router federation rename when:
> # Both the src and dst has only one remote location.
> # The src and dst remote locations are at different namespaces.
> # The src is a directory.(Fedbalance depends on snapshot).
> # The dst doesn't exist.
> We can implement router federation rename of file in a new task so the patch
> won't be too big to review.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
