[
https://issues.apache.org/jira/browse/HDFS-15740?focusedWorklogId=539162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539162
]
ASF GitHub Bot logged work on HDFS-15740:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/21 16:17
Start Date: 21/Jan/21 16:17
Worklog Time Spent: 10m
Work Description: GauthamBanasandra commented on a change in pull request
#2567:
URL: https://github.com/apache/hadoop/pull/2567#discussion_r562010031
##########
File path: dev-support/docker/Dockerfile
##########
@@ -92,6 +96,21 @@ ENV MAVEN_HOME /usr
ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64
ENV FINDBUGS_HOME /usr
+#######
Review comment:
@goiri , @aajisaka , @ayushtkn I tried to upgrade to Focal and it seems
like a lot of unit tests are failing -
https://github.com/apache/hadoop/pull/2613#issuecomment-761768659.
I ran all the tests on the current trunk and interestingly, there are
already so many existing unit test failures -
https://github.com/apache/hadoop/pull/2623#issuecomment-761741221
I would like to request that we decouple this PR from upgrading to Focal and
proceed with the review of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 539162)
Remaining Estimate: 18h 40m (was: 18h 50m)
Time Spent: 5h 20m (was: 5h 10m)
> Make basename cross-platform
> ----------------------------
>
> Key: HDFS-15740
> URL: https://issues.apache.org/jira/browse/HDFS-15740
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs++
> Affects Versions: 3.4.0
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 24h
> Time Spent: 5h 20m
> Remaining Estimate: 18h 40m
>
> The *basename* function isn't available on Visual Studio 2019 compiler. We
> need to make it cross platform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
