[
https://issues.apache.org/jira/browse/HDFS-15953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315487#comment-17315487
]
Viraj Jasani commented on HDFS-15953:
-------------------------------------
Nice find. Arrays#equals is already being used in a couple of places for
DUMMY_CLIENT_ID, except for hasRpcIds() method. We should update it.
> DUMMY_CLIENT_ID's verification may be invalid
> ---------------------------------------------
>
> Key: HDFS-15953
> URL: https://issues.apache.org/jira/browse/HDFS-15953
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Xiaoxing Wei
> Priority: Minor
>
> *_rpcClientId != RpcConstants.DUMMY_CLIENT_ID_* in *_FSEditLogOp#hasRpcIds()_*
> {code:java}
> // code placeholder
> public boolean hasRpcIds() {
> return rpcClientId != RpcConstants.DUMMY_CLIENT_ID
> && rpcCallId != RpcConstants.INVALID_CALL_ID;
> }
> {code}
>
> determine that two arrays are equal should use "Arrays.equals"
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
