[
https://issues.apache.org/jira/browse/HDFS-15953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315945#comment-17315945
]
Xiaoqiao He commented on HDFS-15953:
------------------------------------
Thanks [~daryn] for your kindly reminder. I try to review code and the original
design(HDFS-5025). It seems keep object comparison to decide if Op has RPC id
is more reasonable here. For other case, such as
org.apache.hadoop.ipc.Client#checkResponse, id is received and deserialized
from server side, objection comparison does not works fine as expected. Please
correct me if something I understand wrong. Thanks [~daryn] again.
cc [~weisonwei] we should keep the original comparison here. If you have no
more comments, I will close this issue and mark as `Not a Bug`. what do you
think?
> DUMMY_CLIENT_ID's verification may be invalid
> ---------------------------------------------
>
> Key: HDFS-15953
> URL: https://issues.apache.org/jira/browse/HDFS-15953
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Xiaoxing Wei
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> *_rpcClientId != RpcConstants.DUMMY_CLIENT_ID_* in *_FSEditLogOp#hasRpcIds()_*
> {code:java}
> // code placeholder
> public boolean hasRpcIds() {
> return rpcClientId != RpcConstants.DUMMY_CLIENT_ID
> && rpcCallId != RpcConstants.INVALID_CALL_ID;
> }
> {code}
>
> determine that two arrays are equal should use "Arrays.equals"
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
