[
https://issues.apache.org/jira/browse/HDFS-15975?focusedWorklogId=583162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-583162
]
ASF GitHub Bot logged work on HDFS-15975:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/21 06:15
Start Date: 15/Apr/21 06:15
Worklog Time Spent: 10m
Work Description: tomscut commented on a change in pull request #2907:
URL: https://github.com/apache/hadoop/pull/2907#discussion_r613783259
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
##########
@@ -771,7 +771,7 @@ private void printStatistics(boolean force) {
.append(" Total time for transactions(ms): ")
.append(totalTimeTransactions)
.append(" Number of transactions batched in Syncs: ")
- .append(numTransactionsBatchedInSync.get())
+ .append(numTransactionsBatchedInSync.longValue())
Review comment:
> How frequently this gets printed compared to `longSync()`?
At present, it is printed once a minute. I have not changed this frequency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 583162)
Time Spent: 1h 10m (was: 1h)
> Use LongAdder instead of AtomicLong
> -----------------------------------
>
> Key: HDFS-15975
> URL: https://issues.apache.org/jira/browse/HDFS-15975
> Project: Hadoop HDFS
> Issue Type: Wish
> Reporter: tomscut
> Assignee: tomscut
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When counting some indicators, we can use LongAdder instead of AtomicLong to
> improve performance. The long value is not an atomic snapshot in LongAdder,
> but I think we can tolerate that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
