[
https://issues.apache.org/jira/browse/HDFS-15975?focusedWorklogId=584162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584162
]
ASF GitHub Bot logged work on HDFS-15975:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/21 09:20
Start Date: 16/Apr/21 09:20
Worklog Time Spent: 10m
Work Description: tasanuma commented on a change in pull request #2907:
URL: https://github.com/apache/hadoop/pull/2907#discussion_r614693047
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetCache.java
##########
@@ -607,11 +608,11 @@ public long getCacheCapacity() {
}
public long getNumBlocksFailedToCache() {
- return numBlocksFailedToCache.get();
+ return numBlocksFailedToCache.longValue();
}
public long getNumBlocksFailedToUncache() {
- return numBlocksFailedToUncache.get();
+ return numBlocksFailedToUncache.longValue();
}
public long getNumBlocksCached() {
Review comment:
@tomscut Now we can remove `import
java.util.concurrent.atomic.AtomicLong` in FsDatasetCache.java. Others look
good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 584162)
Time Spent: 2h 40m (was: 2.5h)
> Use LongAdder instead of AtomicLong
> -----------------------------------
>
> Key: HDFS-15975
> URL: https://issues.apache.org/jira/browse/HDFS-15975
> Project: Hadoop HDFS
> Issue Type: Wish
> Reporter: tomscut
> Assignee: tomscut
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> When counting some indicators, we can use LongAdder instead of AtomicLong to
> improve performance. The long value is not an atomic snapshot in LongAdder,
> but I think we can tolerate that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
