[
https://issues.apache.org/jira/browse/HDFS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176115#comment-13176115
]
Harsh J commented on HDFS-1314:
-------------------------------
Thanks for the revised patch Sho - this looks good. Only a few further, mostly
docs related, comments that pertain to HDFS:
- For hdfs.c, would it be possible for you to also switch the blockSize and
replication loading to use jFS's getDefaultBlockSize and getDefaultReplication
calls instead of loading from Configuration? Would be a nice cleanup but if you
want to pursue this on another JIRA please open a new one and we can do it
there overall.
- You can add more documentation notes to cluster_setup, explaining the most
common prefixes (k, m, g) can be provided for block sizes instead of long
values. Also worth it if you add the prefix list to the {{hdfs-default.xml}}
docs.
> dfs.block.size accepts only absolute value
> ------------------------------------------
>
> Key: HDFS-1314
> URL: https://issues.apache.org/jira/browse/HDFS-1314
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Karim Saadah
> Assignee: Sho Shimauchi
> Priority: Minor
> Labels: newbie
> Attachments: hdfs-1314.txt, hdfs-1314.txt
>
>
> Using "dfs.block.size=8388608" works
> but "dfs.block.size=8mb" does not.
> Using "dfs.block.size=8mb" should throw some WARNING on NumberFormatException.
> (http://pastebin.corp.yahoo.com/56129)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
