[
https://issues.apache.org/jira/browse/HDFS-16137?focusedWorklogId=627433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627433
]
ASF GitHub Bot logged work on HDFS-16137:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/21 06:24
Start Date: 25/Jul/21 06:24
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3226:
URL: https://github.com/apache/hadoop/pull/3226#discussion_r676091486
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java
##########
@@ -58,7 +58,10 @@
public static final Logger LOG =
LoggerFactory.getLogger(FairCallQueue.class);
- /* The queues */
+ /*
+ * Save the queue data of multiple priority strategies.
+ * Usually the number of queue data and priority strategies saved is the same.
+ * */
private final ArrayList<BlockingQueue<E>> queues;
Review comment:
Also, good to convert this to `private final List<BlockingQueue<E>>
queues` if you would like to consider as part of this PR.
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java
##########
@@ -58,7 +58,10 @@
public static final Logger LOG =
LoggerFactory.getLogger(FairCallQueue.class);
- /* The queues */
+ /*
+ * Save the queue data of multiple priority strategies.
+ * Usually the number of queue data and priority strategies saved is the same.
+ * */
Review comment:
nit: minor change and alignment of comment section:
```
/**
* Save the queue data of multiple priority strategies as list of blocking
queues.
* Usually the number of queue data and priority strategies saved is the
same.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 627433)
Time Spent: 0.5h (was: 20m)
> Improve the comments related to FairCallQueue#queues
> ----------------------------------------------------
>
> Key: HDFS-16137
> URL: https://issues.apache.org/jira/browse/HDFS-16137
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ipc
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> FairCallQueue#queues related comments are too simple:
> /* The queues */
> private final ArrayList<BlockingQueue<E>> queues;
> Can not visually see the meaning of FairCallQueue#queues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
