[
https://issues.apache.org/jira/browse/HDFS-16137?focusedWorklogId=628113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628113
]
ASF GitHub Bot logged work on HDFS-16137:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/21 02:58
Start Date: 27/Jul/21 02:58
Worklog Time Spent: 10m
Work Description: jojochuang commented on a change in pull request #3226:
URL: https://github.com/apache/hadoop/pull/3226#discussion_r677080813
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java
##########
@@ -20,11 +20,7 @@
import java.lang.ref.WeakReference;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.Iterator;
-import java.util.AbstractQueue;
-import java.util.HashMap;
+import java.util.*;
Review comment:
just a minor code style issue. We typically don't do wildcard imports in
Hadoop codebase.
You can configure your IDE to not automatically collapse multiple imports
into one wildcard import.
Other than that I am +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 628113)
Time Spent: 50m (was: 40m)
> Improve the comments related to FairCallQueue#queues
> ----------------------------------------------------
>
> Key: HDFS-16137
> URL: https://issues.apache.org/jira/browse/HDFS-16137
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ipc
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> FairCallQueue#queues related comments are too simple:
> /* The queues */
> private final ArrayList<BlockingQueue<E>> queues;
> Can not visually see the meaning of FairCallQueue#queues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
