[
https://issues.apache.org/jira/browse/HDFS-16151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391871#comment-17391871
]
JiangHua Zhu commented on HDFS-16151:
-------------------------------------
[~weichiu] [~hexiaoqiao], I look forward to your review of the code I
submitted. If there are any imperfections, I am willing to make more
contributions.
thank you very much.
> Improve the parameter comments related to ProtobufRpcEngine2#Server()
> ---------------------------------------------------------------------
>
> Key: HDFS-16151
> URL: https://issues.apache.org/jira/browse/HDFS-16151
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Now missing some parameter comments related to ProtobufRpcEngine2#Server(),
> as follows:
> /**
> * Construct an RPC server.
> *
> * @param protocolClass the class of protocol
> * @param protocolImpl the protocolImpl whose methods will be called
> * @param conf the configuration to use
> * @param bindAddress the address to bind on to listen for connection
> * @param port the port to listen for connections on
> * @param numHandlers the number of method handler threads to run
> * @param verbose whether each call should be logged
> * @param portRangeConfig A config parameter that can be used to restrict
> * the range of ports used when port is 0 (an ephemeral port)
> * @param alignmentContext provides server state info on client responses
> */
> public Server(Class<?> protocolClass, Object protocolImpl,
> Configuration conf, String bindAddress, int port, int numHandlers,
> int numReaders, int queueSizePerHandler, boolean verbose,
> SecretManager<? extends TokenIdentifier> secretManager,
> String portRangeConfig, AlignmentContext alignmentContext)
> throws IOException {
> super(protocolClass, protocolImpl, conf, bindAddress, port, numHandlers,
> numReaders, queueSizePerHandler, verbose, secretManager,
> portRangeConfig, alignmentContext);
> }
> The description of numReaders, queueSizePerHandler, and secretManager is
> missing here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
