[
https://issues.apache.org/jira/browse/HDFS-16153?focusedWorklogId=634511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634511
]
ASF GitHub Bot logged work on HDFS-16153:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/21 12:06
Start Date: 05/Aug/21 12:06
Worklog Time Spent: 10m
Work Description: sodonnel commented on a change in pull request #3269:
URL: https://github.com/apache/hadoop/pull/3269#discussion_r683390561
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java
##########
@@ -618,9 +620,10 @@ private void selectStreamingInputStreams(
Map<AsyncLogger, RemoteEditLogManifest> resps =
loggers.waitForWriteQuorum(q, selectInputStreamsTimeoutMs,
"selectStreamingInputStreams");
-
- LOG.debug("selectStreamingInputStream manifests:\n" +
- Joiner.on("\n").withKeyValueSeparator(": ").join(resps));
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("selectStreamingInputStream manifests:\n" +
+ Joiner.on("\n").withKeyValueSeparator(": ").join(resps));
+ }
Review comment:
In this case, I don't think there is a simple way to avoid the
evaluation without the `if (LOG.isDebugEnabled())`, so this one is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 634511)
Time Spent: 40m (was: 0.5h)
> Avoid evaluation of LOG.debug statement in QuorumJournalManager
> ---------------------------------------------------------------
>
> Key: HDFS-16153
> URL: https://issues.apache.org/jira/browse/HDFS-16153
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: wangzhaohui
> Assignee: wangzhaohui
> Priority: Trivial
> Labels: patch-available, pull-request-available
> Attachments: HDFS-16153-001_patch.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
