[
https://issues.apache.org/jira/browse/HDFS-16153?focusedWorklogId=634596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634596
]
ASF GitHub Bot logged work on HDFS-16153:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/21 14:20
Start Date: 05/Aug/21 14:20
Worklog Time Spent: 10m
Work Description: sodonnel commented on a change in pull request #3269:
URL: https://github.com/apache/hadoop/pull/3269#discussion_r683499117
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java
##########
@@ -618,8 +618,7 @@ private void selectStreamingInputStreams(
Map<AsyncLogger, RemoteEditLogManifest> resps =
loggers.waitForWriteQuorum(q, selectInputStreamsTimeoutMs,
"selectStreamingInputStreams");
-
- LOG.debug("selectStreamingInputStream manifests:\n" +
+ LOG.debug("selectStreamingInputStream manifests:\n {}",
Review comment:
This one still needs wrapped in `if (LOG.isDebugEnable)` otherwise the
`Joiner` will always be evaluated before the parameters are passed to the
logger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 634596)
Time Spent: 1h 20m (was: 1h 10m)
> Avoid evaluation of LOG.debug statement in QuorumJournalManager
> ---------------------------------------------------------------
>
> Key: HDFS-16153
> URL: https://issues.apache.org/jira/browse/HDFS-16153
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: wangzhaohui
> Assignee: wangzhaohui
> Priority: Trivial
> Labels: patch-available, pull-request-available
> Attachments: HDFS-16153-001_patch.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
