[
https://issues.apache.org/jira/browse/HDFS-16183?focusedWorklogId=641780&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641780
]
ASF GitHub Bot logged work on HDFS-16183:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/21 16:10
Start Date: 25/Aug/21 16:10
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #3328:
URL: https://github.com/apache/hadoop/pull/3328#discussion_r695904216
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
##########
@@ -517,7 +517,6 @@ private Object invokeMethod(
// Communication retries are handled by the retry policy
if (this.rpcMonitor != null) {
this.rpcMonitor.proxyOpFailureCommunicate();
- this.rpcMonitor.proxyOpComplete(false);
Review comment:
True, I didn't realize that the proxyOpComplete just skips this.
We would need to log the failures here though.
As it is the success flag doesn't make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 641780)
Time Spent: 50m (was: 40m)
> RBF: Delete unnecessary metric of proxyOpComplete in routerRpcClient
> ---------------------------------------------------------------------
>
> Key: HDFS-16183
> URL: https://issues.apache.org/jira/browse/HDFS-16183
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: wangzhaohui
> Assignee: wangzhaohui
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In routerRpcClient, this.rpcMonitor.proxyOpComplete(false) do nothing, so
> maybe it doesn't need to exist.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
