[
https://issues.apache.org/jira/browse/HDFS-16183?focusedWorklogId=643266&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643266
]
ASF GitHub Bot logged work on HDFS-16183:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/21 02:37
Start Date: 30/Aug/21 02:37
Worklog Time Spent: 10m
Work Description: wzhallright commented on a change in pull request #3328:
URL: https://github.com/apache/hadoop/pull/3328#discussion_r698125313
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
##########
@@ -517,7 +517,6 @@ private Object invokeMethod(
// Communication retries are handled by the retry policy
if (this.rpcMonitor != null) {
this.rpcMonitor.proxyOpFailureCommunicate();
- this.rpcMonitor.proxyOpComplete(false);
Review comment:
Thanks for review @ayushtkn ,I have added a LOG, could you help
review.Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 643266)
Time Spent: 1h 20m (was: 1h 10m)
> RBF: Delete unnecessary metric of proxyOpComplete in routerRpcClient
> ---------------------------------------------------------------------
>
> Key: HDFS-16183
> URL: https://issues.apache.org/jira/browse/HDFS-16183
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: wangzhaohui
> Assignee: wangzhaohui
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In routerRpcClient, this.rpcMonitor.proxyOpComplete(false) do nothing, so
> maybe it doesn't need to exist.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
