[
https://issues.apache.org/jira/browse/HDFS-16287?focusedWorklogId=678018&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-678018
]
ASF GitHub Bot logged work on HDFS-16287:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/21 03:51
Start Date: 06/Nov/21 03:51
Worklog Time Spent: 10m
Work Description: tomscut commented on a change in pull request #3596:
URL: https://github.com/apache/hadoop/pull/3596#discussion_r744070877
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
##########
@@ -394,6 +395,23 @@ public void testEnableParallelLoadAfterReconfigured()
assertEquals(true, FSImageFormatProtobuf.getEnableParallelLoad());
}
+ @Test
+ public void testEnableSlowNodesParametersAfterReconfigured()
+ throws ReconfigurationException {
+ final NameNode nameNode = cluster.getNameNode();
+ final DatanodeManager datanodeManager = nameNode.namesystem
+ .getBlockManager().getDatanodeManager();
+
+ // By default, avoidSlowDataNodesForRead is false
Review comment:
According to the standard of previous review, a period should be added
after the comment.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
##########
@@ -394,6 +395,23 @@ public void testEnableParallelLoadAfterReconfigured()
assertEquals(true, FSImageFormatProtobuf.getEnableParallelLoad());
}
+ @Test
+ public void testEnableSlowNodesParametersAfterReconfigured()
+ throws ReconfigurationException {
+ final NameNode nameNode = cluster.getNameNode();
+ final DatanodeManager datanodeManager = nameNode.namesystem
+ .getBlockManager().getDatanodeManager();
+
+ // By default, avoidSlowDataNodesForRead is false
+ assertEquals(false, datanodeManager.getEnableAvoidSlowDataNodesForRead());
+
+ nameNode.reconfigureProperty(
+ DFS_NAMENODE_AVOID_SLOW_DATANODE_FOR_READ_KEY, Boolean.toString(true));
+
+ // After reconfigured, avoidSlowDataNodesForRead is true
Review comment:
Please add a period after the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 678018)
Time Spent: 10h 20m (was: 10h 10m)
> Support to make dfs.namenode.avoid.read.slow.datanode reconfigurable
> ---------------------------------------------------------------------
>
> Key: HDFS-16287
> URL: https://issues.apache.org/jira/browse/HDFS-16287
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> 1. Consider that make dfs.namenode.avoid.read.slow.datanode reconfigurable
> and rapid rollback in case this feature
> [HDFS-16076|https://issues.apache.org/jira/browse/HDFS-16076] unexpected
> things happen in production environment
> 2. DatanodeManager#startSlowPeerCollector by parameter
> 'dfs.datanode.peer.stats.enabled' to control
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
