[ 
https://issues.apache.org/jira/browse/HDFS-16543?focusedWorklogId=757363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757363
 ]

ASF GitHub Bot logged work on HDFS-16543:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Apr/22 09:00
            Start Date: 15/Apr/22 09:00
    Worklog Time Spent: 10m 
      Work Description: cndaimin opened a new pull request, #4178:
URL: https://github.com/apache/hadoop/pull/4178

   `WARN datanode.DirectoryScanner (DirectoryScanner.java:<init>(300)) - 
dfs.datanode.directoryscan.throttle.limit.ms.per.sec set to value above 1000 
ms/sec. Assuming default value of -1`
   A warning log like above will be printed when datanode is starting. The 
reason of that is the default value of 
`dfs.datanode.directoryscan.throttle.limit.ms.per.sec` is 1000 in 
hdfs-site.xml, and is -1 in 
`DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT`. We should try 
to keep it consistent, and value -1 looks is better to 1000.
   
   The code segment that print the warning log:
   ```
   if (throttle >= TimeUnit.SECONDS.toMillis(1)) {
     LOG.warn(
         "{} set to value above 1000 ms/sec. Assuming default value of {}",
         DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_KEY,
         
DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT);
     throttle =
         
DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT;
   }
   ```




Issue Time Tracking
-------------------

            Worklog Id:     (was: 757363)
    Remaining Estimate: 0h
            Time Spent: 10m

> Keep default value of dfs.datanode.directoryscan.throttle.limit.ms.per.sec 
> consistent
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-16543
>                 URL: https://issues.apache.org/jira/browse/HDFS-16543
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: configuration, datanode
>    Affects Versions: 3.3.2
>            Reporter: daimin
>            Assignee: daimin
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> "WARN  datanode.DirectoryScanner (DirectoryScanner.java:<init>(300)) - 
> dfs.datanode.directoryscan.throttle.limit.ms.per.sec set to value above 1000 
> ms/sec. Assuming default value of -1"
> A warning log like above will be printed when datanode is starting. The 
> reason of that is the default value of 
> dfs.datanode.directoryscan.throttle.limit.ms.per.sec is 1000 in 
> hdfs-site.xml, and is -1 in 
> DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT. We should try 
> to keep it consistent, and value -1 looks is better to 1000.
> The code segment that print the warning log:
> if (throttle >= TimeUnit.SECONDS.toMillis(1)) {
>   LOG.warn(
>       "{} set to value above 1000 ms/sec. Assuming default value of {}",
>       DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_KEY,
>       
> DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT);
>   throttle =
>       
> DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT;
> }



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to