[
https://issues.apache.org/jira/browse/HDFS-16543?focusedWorklogId=764816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764816
]
ASF GitHub Bot logged work on HDFS-16543:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/22 00:18
Start Date: 02/May/22 00:18
Worklog Time Spent: 10m
Work Description: tomscut commented on code in PR #4178:
URL: https://github.com/apache/hadoop/pull/4178#discussion_r862542228
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml:
##########
@@ -885,7 +885,7 @@
<property>
<name>dfs.datanode.directoryscan.throttle.limit.ms.per.sec</name>
- <value>1000</value>
+ <value>-1</value>
Review Comment:
LGTM. But the comment `1000 is the default setting` also needs to update.
Issue Time Tracking
-------------------
Worklog Id: (was: 764816)
Time Spent: 40m (was: 0.5h)
> Keep default value of dfs.datanode.directoryscan.throttle.limit.ms.per.sec
> consistent
> -------------------------------------------------------------------------------------
>
> Key: HDFS-16543
> URL: https://issues.apache.org/jira/browse/HDFS-16543
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: configuration, datanode
> Affects Versions: 3.3.2
> Reporter: daimin
> Assignee: daimin
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> "WARN datanode.DirectoryScanner (DirectoryScanner.java:<init>(300)) -
> dfs.datanode.directoryscan.throttle.limit.ms.per.sec set to value above 1000
> ms/sec. Assuming default value of -1"
> A warning log like above will be printed when datanode is starting. The
> reason of that is the default value of
> dfs.datanode.directoryscan.throttle.limit.ms.per.sec is 1000 in
> hdfs-site.xml, and is -1 in
> DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT. We should try
> to keep it consistent, and value -1 looks is better to 1000.
> The code segment that print the warning log:
> if (throttle >= TimeUnit.SECONDS.toMillis(1)) {
> LOG.warn(
> "{} set to value above 1000 ms/sec. Assuming default value of {}",
> DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_KEY,
>
> DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT);
> throttle =
>
> DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT;
> }
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
