[
https://issues.apache.org/jira/browse/HDFS-16555?focusedWorklogId=761374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761374
]
ASF GitHub Bot logged work on HDFS-16555:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/22 02:03
Start Date: 24/Apr/22 02:03
Worklog Time Spent: 10m
Work Description: GuoPhilipse commented on PR #4216:
URL: https://github.com/apache/hadoop/pull/4216#issuecomment-1107685324
> api is tagged as @InterfaceAudience.Public;; we can't remove the existing
method. you could add a new one with the better name and mark the old one as
deprecated
Cool..Thanks @steveloughran for your nice advice ,have just add the older
method as deprecated and pushed
Issue Time Tracking
-------------------
Worklog Id: (was: 761374)
Time Spent: 40m (was: 0.5h)
> rename mixlead method name in DistCpOptions
> -------------------------------------------
>
> Key: HDFS-16555
> URL: https://issues.apache.org/jira/browse/HDFS-16555
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: distcp
> Affects Versions: 3.3.2
> Reporter: guophilipse
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently method in DistCpOptions withCRC was used as the following
> ```
> withCRC(true) means check without crc
> withCRC(false) means check with crc
> ```
> which mislead the developer when we pass the paramter, we can rename the
> method to clear that.after that it should be:
> ```
> withSkipCRC(true) means check without crc
> withSkipCRC(false) means check with crc
> ```
> so it will be more understandable.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
