[
https://issues.apache.org/jira/browse/HDFS-16555?focusedWorklogId=774313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774313
]
ASF GitHub Bot logged work on HDFS-16555:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/22 00:56
Start Date: 25/May/22 00:56
Worklog Time Spent: 10m
Work Description: GuoPhilipse commented on code in PR #4216:
URL: https://github.com/apache/hadoop/pull/4216#discussion_r881089014
##########
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptions.java:
##########
@@ -684,11 +684,23 @@ public Builder withAppend(boolean newAppend) {
return this;
}
+ /**
+ * whether builder with crc.
+ * @param newSkipCRC whether to skip crc check
+ * @return Builder object whether to skip crc check
+ * @deprecated Use {@link #withSkipCRC(boolean)} instead.
+ */
+ @Deprecated
public Builder withCRC(boolean newSkipCRC) {
this.skipCRC = newSkipCRC;
return this;
}
+ public Builder withSkipCRC(boolean newSkipCRC) {
Review Comment:
> copy the javadocs from above, now you've written them
Thanks @steveloughran for your notice ,have just updated
Issue Time Tracking
-------------------
Worklog Id: (was: 774313)
Time Spent: 1h 40m (was: 1.5h)
> rename mixlead method name in DistCpOptions
> -------------------------------------------
>
> Key: HDFS-16555
> URL: https://issues.apache.org/jira/browse/HDFS-16555
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: distcp
> Affects Versions: 3.3.2
> Reporter: guophilipse
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently method in DistCpOptions withCRC was used as the following
> ```
> withCRC(true) means check without crc
> withCRC(false) means check with crc
> ```
> which mislead the developer when we pass the paramter, we can rename the
> method to clear that.after that it should be:
> ```
> withSkipCRC(true) means check without crc
> withSkipCRC(false) means check with crc
> ```
> so it will be more understandable.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
