[
https://issues.apache.org/jira/browse/HDFS-16558?focusedWorklogId=762681&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762681
]
ASF GitHub Bot logged work on HDFS-16558:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/22 03:36
Start Date: 27/Apr/22 03:36
Worklog Time Spent: 10m
Work Description: Hexiaoqiao commented on PR #4230:
URL: https://github.com/apache/hadoop/pull/4230#issuecomment-1110498309
`In a very busy authed cluster, renewing/caneling/getting delegation token
get slow and it will slow down the speed of handling rpcs from client. Since
AbstractDelegationTokenSecretManager is a thread-safe manager, we propose to
change the fs lock from write lock to read lock(protect editlog rolling)`
@yuanboliu Thanks for your proposal, it is a great improvement. I think it
is proper for ADTS which is thread-safe as you mentioned above. But I am
concern if it is also thread-safe for editlog sync. Consider both
renew/cancel/get for different token, is it safe to keep the order when replay
editlog? Thanks.
Issue Time Tracking
-------------------
Worklog Id: (was: 762681)
Time Spent: 1h 40m (was: 1.5h)
> Consider changing the lock of delegation token from write lock to read lock
> ---------------------------------------------------------------------------
>
> Key: HDFS-16558
> URL: https://issues.apache.org/jira/browse/HDFS-16558
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Yuanbo Liu
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2022-04-24-14-13-04-695.png,
> image-2022-04-24-14-13-52-867.png, image-2022-04-24-14-57-18-740.png,
> image-2022-04-24-14-58-25-294.png
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> In a very busy authed cluster, renewing/caneling/getting delegation token get
> slow and it will slow down the speed of handling rpcs from client. Since
> AbstractDelegationTokenSecretManager is a thread-safe manager, we propose to
> change the fs lock from write lock to read lock(protect editlog rolling)
> !image-2022-04-24-14-58-25-294.png|width=318,height=194!
> !image-2022-04-24-14-13-52-867.png|width=324,height=173!
> !image-2022-04-24-14-57-18-740.png|width=303,height=184!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
