[
https://issues.apache.org/jira/browse/HDFS-16558?focusedWorklogId=763265&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763265
]
ASF GitHub Bot logged work on HDFS-16558:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/22 02:42
Start Date: 28/Apr/22 02:42
Worklog Time Spent: 10m
Work Description: yuanboliu commented on PR #4230:
URL: https://github.com/apache/hadoop/pull/4230#issuecomment-1111680424
@Hexiaoqiao Thanks for your comments.
We will apply this patch to our test env, and give feedback here.
This is the code from trunk to prove that read lock is good enough:
<img width="762" alt="image"
src="https://user-images.githubusercontent.com/5643344/165666072-023f7b39-3499-405e-bfd5-1ff1412ab9e1.png";>
edit sync is protected by synchronized (this), and renew/cancel/get are
in-order requests, there is no way that all the requests for one uniq token
will be handled at the same time.
Issue Time Tracking
-------------------
Worklog Id: (was: 763265)
Time Spent: 1h 50m (was: 1h 40m)
> Consider changing the lock of delegation token from write lock to read lock
> ---------------------------------------------------------------------------
>
> Key: HDFS-16558
> URL: https://issues.apache.org/jira/browse/HDFS-16558
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Yuanbo Liu
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2022-04-24-14-13-04-695.png,
> image-2022-04-24-14-13-52-867.png, image-2022-04-24-14-57-18-740.png,
> image-2022-04-24-14-58-25-294.png
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> In a very busy authed cluster, renewing/caneling/getting delegation token get
> slow and it will slow down the speed of handling rpcs from client. Since
> AbstractDelegationTokenSecretManager is a thread-safe manager, we propose to
> change the fs lock from write lock to read lock(protect editlog rolling)
> !image-2022-04-24-14-58-25-294.png|width=318,height=194!
> !image-2022-04-24-14-13-52-867.png|width=324,height=173!
> !image-2022-04-24-14-57-18-740.png|width=303,height=184!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/5643344/165666072-023f7b39-3499-405e-bfd5-1ff1412ab9e1.png"](https://user-images.githubusercontent.com/5643344/165666072-023f7b39-3499-405e-bfd5-1ff1412ab9e1.png"){kind=link}