[ 
https://issues.apache.org/jira/browse/HDFS-13522?focusedWorklogId=779610&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779610
 ]

ASF GitHub Bot logged work on HDFS-13522:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Jun/22 18:17
            Start Date: 08/Jun/22 18:17
    Worklog Time Spent: 10m 
      Work Description: hchaverri commented on code in PR #4311:
URL: https://github.com/apache/hadoop/pull/4311#discussion_r892717426


##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java:
##########
@@ -40,6 +40,14 @@ public class ClientGSIContext implements AlignmentContext {
   private final LongAccumulator lastSeenStateId =
       new LongAccumulator(Math::max, Long.MIN_VALUE);
 
+  public void disableObserverRead() {
+    if(lastSeenStateId.get() > -1L) {

Review Comment:
   Should we be repurposing the accumulator to define the state? Could -1L be a 
valid value on the header stateId that might break this? Should we use a 
boolean instead?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 779610)
    Time Spent: 9.5h  (was: 9h 20m)

> RBF: Support observer node from Router-Based Federation
> -------------------------------------------------------
>
>                 Key: HDFS-13522
>                 URL: https://issues.apache.org/jira/browse/HDFS-13522
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: federation, namenode
>            Reporter: Erik Krogen
>            Assignee: Simbarashe Dzinamarira
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HDFS-13522.001.patch, HDFS-13522.002.patch, 
> HDFS-13522_WIP.patch, RBF_ Observer support.pdf, Router+Observer RPC 
> clogging.png, ShortTerm-Routers+Observer.png
>
>          Time Spent: 9.5h
>  Remaining Estimate: 0h
>
> Changes will need to occur to the router to support the new observer node.
> One such change will be to make the router understand the observer state, 
> e.g. {{FederationNamenodeServiceState}}.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to