[
https://issues.apache.org/jira/browse/HDFS-16631?focusedWorklogId=781450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781450
]
ASF GitHub Bot logged work on HDFS-16631:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/22 02:43
Start Date: 15/Jun/22 02:43
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4438:
URL: https://github.com/apache/hadoop/pull/4438#issuecomment-1155921035
@MingXiangLi @ZanderXu Thanks for helping to review the code, can I make the
following changes?
```
public void lockLeakCheck() throws Exception {
if (!openLockTrace) {
LOG.warn("not open lock leak check func");
return;
}
if (threadCountMap.isEmpty()) {
LOG.warn("all lock has release");
return;
}
setLastException(new Exception("lock Leak"));
threadCountMap.forEach((name, trackLog) -> trackLog.showLockMessage());
// throw exception ?
throw new Exception("lock Leak");
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 781450)
Time Spent: 1.5h (was: 1h 20m)
> Enable dfs.datanode.lockmanager.trace In Test
> ---------------------------------------------
>
> Key: HDFS-16631
> URL: https://issues.apache.org/jira/browse/HDFS-16631
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In Jira HDFS-16600. Fix deadlock on DataNode side. We discussed the issue of
> deadlock, this is a very meaningful discussion, I was reading the log and
> found the following:
> {code:java}
> 2022-05-27 07:39:47,890 [Listener at localhost/36941] WARN
> datanode.DataSetLockManager (DataSetLockManager.java:lockLeakCheck(261)) -
> not open lock leak check func.{code}
> Looking at the code, I found that there is such a parameter:
> {code:java}
> <property>
> <name>dfs.datanode.lockmanager.trace</name>
> <value>false</value>
> <description>
> If this is true, after shut down datanode lock Manager will print all
> leak
> thread that not release by lock Manager. Only used for test or trace
> dead lock
> problem. In produce default set false, because it's have little
> performance loss.
> </description>
> </property> {code}
> I think this parameter should be added in the test environment, so that if
> there is a DN deadlock, the cause can be quickly located.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
