[ https://issues.apache.org/jira/browse/HDFS-16631?focusedWorklogId=782449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782449 ]
ASF GitHub Bot logged work on HDFS-16631: ----------------------------------------- Author: ASF GitHub Bot Created on: 17/Jun/22 15:55 Start Date: 17/Jun/22 15:55 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4438: URL: https://github.com/apache/hadoop/pull/4438#issuecomment-1159014765 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 53s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +0 :ok: | xmllint | 0m 0s | | xmllint was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 39m 28s | | trunk passed | | +1 :green_heart: | shadedclient | 61m 49s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 25s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | shadedclient | 21m 58s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 27s | | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 0m 45s | | The patch does not generate ASF License warnings. | | | | 91m 14s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4438/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4438 | | Optional Tests | dupname asflicense unit codespell detsecrets xmllint | | uname | Linux 2672a54c0019 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 30bf6edc6e886f5ec0c6bf24e62a0a5bce4e838a | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4438/3/testReport/ | | Max. process+thread count | 550 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4438/3/console | | versions | git=2.25.1 maven=3.6.3 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. Issue Time Tracking ------------------- Worklog Id: (was: 782449) Time Spent: 2h 10m (was: 2h) > Enable dfs.datanode.lockmanager.trace In Test > --------------------------------------------- > > Key: HDFS-16631 > URL: https://issues.apache.org/jira/browse/HDFS-16631 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Reporter: fanshilun > Assignee: fanshilun > Priority: Minor > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > In Jira HDFS-16600. Fix deadlock on DataNode side. We discussed the issue of > deadlock, this is a very meaningful discussion, I was reading the log and > found the following: > {code:java} > 2022-05-27 07:39:47,890 [Listener at localhost/36941] WARN > datanode.DataSetLockManager (DataSetLockManager.java:lockLeakCheck(261)) - > not open lock leak check func.{code} > Looking at the code, I found that there is such a parameter: > {code:java} > <property> > <name>dfs.datanode.lockmanager.trace</name> > <value>false</value> > <description> > If this is true, after shut down datanode lock Manager will print all > leak > thread that not release by lock Manager. Only used for test or trace > dead lock > problem. In produce default set false, because it's have little > performance loss. > </description> > </property> {code} > I think this parameter should be added in the test environment, so that if > there is a DN deadlock, the cause can be quickly located. > -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org