[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=791388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-791388
]
ASF GitHub Bot logged work on HDFS-16658:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/22 12:39
Start Date: 15/Jul/22 12:39
Worklog Time Spent: 10m
Work Description: Hexiaoqiao commented on code in PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#discussion_r922125850
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -3607,7 +3607,7 @@ private Block addStoredBlock(final BlockInfo block,
curReplicaDelta =
(node.isDecommissioned() || node.isDecommissionInProgress()) ? 0 : 1;
if (logEveryBlock) {
- blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
+ blockLog.info("BLOCK* addStoredBlock: {} is added to {} (size={})",
Review Comment:
+1. Please double check if it could flood general log in some corner case.
Issue Time Tracking
-------------------
Worklog Id: (was: 791388)
Time Spent: 0.5h (was: 20m)
> BlockManager should output some logs when logEveryBlock is true.
> ----------------------------------------------------------------
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
> final Block reportedBlock,
> DatanodeStorageInfo storageInfo,
> DatanodeDescriptor delNodeHint,
> boolean logEveryBlock)
> throws IOException {
> ....
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
