[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=795172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795172
]
ASF GitHub Bot logged work on HDFS-16658:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/22 08:28
Start Date: 26/Jul/22 08:28
Worklog Time Spent: 10m
Work Description: ZanderXu commented on PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#issuecomment-1195172042
Thanks @slfan1989 for your review.
> This command can temporarily modify the log level.
This command can change the log level of the logger. But it will print all
debug log of the logger.
> If you directly modify the log level, will the log size be very large,
after all, this is a block-level log?
The log size is controllable because `logEveryBlock` will control it. And
although it's a block-level log, it only printed the log when the replica of
the block is changed.
Maybe we should think about its use. This log is very helpful for us to
locate some abnormal case about block-level of block, such as complete failure,
missing block, etc...
Issue Time Tracking
-------------------
Worklog Id: (was: 795172)
Time Spent: 1h (was: 50m)
> BlockManager should output some logs when logEveryBlock is true.
> ----------------------------------------------------------------
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
> final Block reportedBlock,
> DatanodeStorageInfo storageInfo,
> DatanodeDescriptor delNodeHint,
> boolean logEveryBlock)
> throws IOException {
> ....
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
