[
https://issues.apache.org/jira/browse/HDFS-16837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632682#comment-17632682
]
ASF GitHub Bot commented on HDFS-16837:
---------------------------------------
hadoop-yetus commented on PR #5123:
URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1312493141
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +0 :ok: | buf | 0m 1s | | buf was not available. |
| +0 :ok: | buf | 0m 1s | | buf was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 15m 41s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 29m 7s | | trunk passed |
| +1 :green_heart: | compile | 6m 56s | | trunk passed with JDK
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 6m 27s | | trunk passed with JDK
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 32s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 56s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 45s | | trunk passed with JDK
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 50s | | trunk passed with JDK
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 4m 24s | | trunk passed |
| +1 :green_heart: | shadedclient | 23m 54s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 31s | | the patch passed |
| +1 :green_heart: | compile | 6m 41s | | the patch passed with JDK
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | cc | 6m 41s | | the patch passed |
| -1 :x: | javac | 6m 41s |
[/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/4/artifact/out/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt)
| hadoop-hdfs-project-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 1 new + 1133 unchanged - 1
fixed = 1134 total (was 1134) |
| +1 :green_heart: | compile | 6m 17s | | the patch passed with JDK
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | cc | 6m 17s | | the patch passed |
| -1 :x: | javac | 6m 17s |
[/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/4/artifact/out/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt)
| hadoop-hdfs-project-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 1 new +
1102 unchanged - 1 fixed = 1103 total (was 1103) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 16s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 34s | | the patch passed |
| -1 :x: | javadoc | 0m 32s |
[/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/4/artifact/out/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt)
|
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 99 new + 0
unchanged - 99 fixed = 99 total (was 99) |
| +1 :green_heart: | javadoc | 1m 32s | | the patch passed with JDK
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| -1 :x: | spotbugs | 3m 4s |
[/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/4/artifact/out/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.html)
| hadoop-hdfs-project/hadoop-hdfs-client generated 39 new + 0 unchanged - 0
fixed = 39 total (was 0) |
| +1 :green_heart: | shadedclient | 24m 0s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 31s | | hadoop-hdfs-client in the patch
passed. |
| -1 :x: | unit | 41m 37s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt)
| hadoop-hdfs-rbf in the patch passed. |
| +1 :green_heart: | asflicense | 0m 41s | | The patch does not
generate ASF License warnings. |
| | | 190m 18s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hadoop-hdfs-project/hadoop-hdfs-client |
| |
org.apache.hadoop.hdfs.ClientGSIContext.mergeRouterFederatedState(ByteString)
makes inefficient use of keySet iterator instead of entrySet iterator At
ClientGSIContext.java:keySet iterator instead of entrySet iterator At
ClientGSIContext.java:[line 123] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$AddMountTableEntryResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
15550] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$DisableNameserviceRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
32175] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$DisableNameserviceResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
32725] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$DisabledNameserviceRecordProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
31511] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$EnableNameserviceRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
33261] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$EnableNameserviceResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
33811] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$EnterSafeModeRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
28594] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$EnterSafeModeResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
29053] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$FederationNamespaceInfoProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
5776] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetDestinationRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
19767] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetDestinationResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
20348] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetDisabledNameservicesRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
34267] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetDisabledNameservicesResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
34757] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetExpiredRegistrationsRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
7849] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetMountTableEntriesRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
18303] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetNamespaceInfoRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
8260] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetRouterRegistrationRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
23244] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetRouterRegistrationsRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
24362] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetSafeModeRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
30424] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetSafeModeResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
30883] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$LeaveSafeModeRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
29509] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$LeaveSafeModeResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
29968] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$NamenodeHeartbeatResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
11532] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$NamenodeMembershipStatsRecordProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
1362] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RefreshMountTableEntriesRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
26764] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RefreshMountTableEntriesResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
27223] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RefreshSuperUserGroupsConfigurationRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
27679] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RefreshSuperUserGroupsConfigurationResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
28138] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RemoteLocationProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
12146] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RemoveMountTableEntryRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
17217] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RemoveMountTableEntryResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
17767] |
| | Class
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RouterFederatedStateProto
defines non-transient non-serializable instance field namespaceStateIds_ In
HdfsServerFederationProtos.java:instance field namespaceStateIds_ In
HdfsServerFederationProtos.java |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RouterFederatedStateProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
35510] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RouterHeartbeatResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
26308] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$StateStoreVersionRecordProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
20965] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$UpdateMountTableEntryResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
16681] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$UpdateNamenodeRegistrationRequestProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
9688] |
| | Useless control flow in
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$UpdateNamenodeRegistrationResponseProto$Builder.maybeForceBuilderInitialization()
At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line
10412] |
| Failed junit tests |
hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver
|
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/4/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/5123 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint
bufcompat |
| uname | Linux 52dfe15fdb85 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 6823812d4702b2daa83ffbae3e8f43a636147055 |
| Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/4/testReport/ |
| Max. process+thread count | 2380 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client
hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/4/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max
> state id for each namespace
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-16837
> URL: https://issues.apache.org/jira/browse/HDFS-16837
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> ClientGSIContext should merge local and remote RouterFederatedState to get
> the max state id for each namespace.
> And the related code as bellows:
> {code:java}
> @Override
> public synchronized void receiveResponseState(RpcResponseHeaderProto header) {
> if (header.hasRouterFederatedState()) {
> // BUG here
> routerFederatedState = header.getRouterFederatedState();
> } else {
> lastSeenStateId.accumulate(header.getStateId());
> }
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
