[
https://issues.apache.org/jira/browse/HDFS-16837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636155#comment-17636155
]
ASF GitHub Bot commented on HDFS-16837:
---------------------------------------
tomscut commented on PR #5123:
URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1320881262
>
> > > What do you think about moving just
> > > > message RouterFederatedStateProto {
> > > > map<string, int64> namespaceStateIds = 1; // Last seen state IDs for
multiple namespaces.
> > > > }
> >
> >
> > @simbadzina Nice suggestion, moving RouterFederatedStateProto to
hdfs.proto?
>
> @ZanderXu Thanks. I was initially thinking of putting it in
ClientNamenodeProtocol.Proto, but hdfs.proto is a good location too.
I agree
> > > What do you think about moving just
> > > > message RouterFederatedStateProto {
> > > > map<string, int64> namespaceStateIds = 1; // Last seen state IDs for
multiple namespaces.
> > > > }
> >
> >
> > @simbadzina Nice suggestion, moving RouterFederatedStateProto to
hdfs.proto?
>
> @ZanderXu Thanks. I was initially thinking of putting it in
ClientNamenodeProtocol.Proto, but hdfs.proto is a good location too.
I think moving RouterFederatedStateProto to hdfs.proto is ok. @goiri Can you
please give some advices. Thank you very much.
> [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max
> state id for each namespace
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-16837
> URL: https://issues.apache.org/jira/browse/HDFS-16837
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> ClientGSIContext should merge local and remote RouterFederatedState to get
> the max state id for each namespace.
> And the related code as bellows:
> {code:java}
> @Override
> public synchronized void receiveResponseState(RpcResponseHeaderProto header) {
> if (header.hasRouterFederatedState()) {
> // BUG here
> routerFederatedState = header.getRouterFederatedState();
> } else {
> lastSeenStateId.accumulate(header.getStateId());
> }
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
