[
https://issues.apache.org/jira/browse/HDFS-16840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636378#comment-17636378
]
ASF GitHub Bot commented on HDFS-16840:
---------------------------------------
tomscut commented on code in PR #5129:
URL: https://github.com/apache/hadoop/pull/5129#discussion_r1027391813
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java:
##########
@@ -81,6 +81,8 @@ public class OfflineImageViewerPB {
+ " changed via the -delimiter argument.\n"
+ " -sp print storage policy, used by delimiter only.\n"
+ " -ec print erasure coding policy, used by delimiter only.\n"
+ + " -m,--multiThread defines multiThread to process sub-sections, \n"
Review Comment:
Are there some duplicated options here?
> Enhance the usage description about oiv in HDFSCommands.md and
> OfflineImageViewerPB
> -----------------------------------------------------------------------------------
>
> Key: HDFS-16840
> URL: https://issues.apache.org/jira/browse/HDFS-16840
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> the usage description about oiv in OfflineImageViewerPB support print out
> storage and erasure coding policy id, -maxSize, -step, -format and -addr.
> maybe can add relevant information in HDFSCommands.md to describe how to use
> it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
